Add fire blending to GOCART #2883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakernoaa
force-pushed
the
feature/fire_blending
branch
from
ee128da
to
fd0e7a5
Compare
bbakernoaa
force-pushed
the
feature/fire_blending
branch
from
fd0e7a5
to
c8e6344
Compare
aerorahul
reviewed
Sep 14, 2024
WalterKolczynski-NOAA
changed the title
aerorahul
added
CI-Gaea-Ready
As forecast ensemble jobs are added to the global workflow, this PR ensures the output is being cleaned up properly once it is no longer needed. Resolves NOAA-EMC#833
This PR updates the parm/config/gfs/config.resources and env/WCOSS2.env files for the BUFR sounding job "postsnd." It includes adjustments to resource settings such as tasks per node and memory allocations for various GFS resolutions, including C768, C1152, and others. Here are the proposed changes: C768: 7 nodes, 21 tasks per node C1152: 16 nodes, 9 tasks per node
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global-workflow Unified Post Processor (UPP) task. Refs: NOAA-EMC#2451
This PR updates the `develop` branch to use the newer operational
`obsproc/v1.2.0` and `prepobs/v1.1.0`. The obsproc/prepobs installs in
glopara space on supported platforms use tags cut from the `dev/gfsv17`
branches in the respective repos. The installation of `prepobs/v1.1.0`
on WCOSS2 is called "gfsv17_v1.1.0" to help avoid GFSv16 users using it
instead of the operational module.
Also, the `HOMEobsproc` path is updated to set an empty default for
`obsproc_run_ver`. This both removes the need to set a default (and
constantly update it, which is duplication) and avoid the unset variable
error when the fcst jobs use their own load module script that does not
know `obsproc_run_ver`:
```
export HOMEobsproc="${BASE_GIT:-}/obsproc/v${obsproc_run_ver:-}"
```
This PR also reverts the prepobs and fit2obs installs on MSU back to the
glopara space from the temporary `/work/noaa/global/kfriedma/glopara`
space installs.
Lastly, this PR also includes updates to complete issue NOAA-EMC#2844 (merge
`build.spack.ver` and `run.spack.ver`).
Resolves NOAA-EMC#2291
Resolves NOAA-EMC#2840
Resolves NOAA-EMC#2844
aerorahul
requested changes
Sep 25, 2024
There was a problem hiding this comment.
@bbakernoaa
Please let me know if any of my comments need clarifications
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
…ng' into feature/fire_blending
Co-authored-by: David Huber <[email protected]>
|
@bbakernoaa |
Co-authored-by: David Huber <[email protected]>
Co-authored-by: David Huber <[email protected]>
resolving comments
WalterKolczynski-NOAA
requested changes
Oct 23, 2024
| # link directory containing GOCART input dataset, if provided | ||
| if [[ -n "${AERO_INPUTS_DIR}" ]]; then | ||
| ${NLN} "${AERO_INPUTS_DIR}" "${DATA}/ExtData" | ||
| status=$? | ||
| [[ ${status} -ne 0 ]] && exit "${status}" | ||
| fi | ||
|
|
||
| # Link blending emissions if AERO_EMIS_FIRE == blending | ||
| if [[ "${AERO_EMIS_FIRE}" == "blending" && "${RUN}" == "gefs" ]]; then |
There was a problem hiding this comment.
Is there a reason for the check against $RUN? Presumably, if $AERO_EMIS_FIRE is blending, we want to use blending regardless of the $RUN.
There was a problem hiding this comment.
I'm not sure... Rahul asked to add this but
There was a problem hiding this comment.
Since this was only GEFS related, I suggested the RUN condition check. Pretty sure, SFS will need that as well in the future.
I can go either way.
There was a problem hiding this comment.
I'd rather rely on the app config to know whether it wants blending.
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
aerorahul
reviewed
Nov 4, 2024
| # link directory containing GOCART input dataset, if provided | ||
| if [[ -n "${AERO_INPUTS_DIR}" ]]; then | ||
| ${NLN} "${AERO_INPUTS_DIR}" "${DATA}/ExtData" | ||
| status=$? | ||
| [[ ${status} -ne 0 ]] && exit "${status}" | ||
| fi | ||
|
|
||
| # Link blending emissions if AERO_EMIS_FIRE == blending | ||
| if [[ "${AERO_EMIS_FIRE}" == "blending" && "${RUN}" == "gefs" ]]; then | ||
| ${NCP} "${COMOUT_CHEM_HISTORY}/${RUN}.${vdate:0:8}.${RUN}.blended_emissions.nc" "${DATA}" |
There was a problem hiding this comment.
Where is vdate coming from in this function scope?
WalterKolczynski-NOAA
requested changes
Nov 7, 2024
| # link directory containing GOCART input dataset, if provided | ||
| if [[ -n "${AERO_INPUTS_DIR}" ]]; then | ||
| ${NLN} "${AERO_INPUTS_DIR}" "${DATA}/ExtData" | ||
| status=$? | ||
| [[ ${status} -ne 0 ]] && exit "${status}" | ||
| fi | ||
|
|
||
| # Link blending emissions if AERO_EMIS_FIRE == blending | ||
| if [[ "${AERO_EMIS_FIRE}" == "blending" && "${RUN}" == "gefs" ]]; then |
There was a problem hiding this comment.
I'd rather rely on the app config to know whether it wants blending.
| -------- | ||
| None | ||
| """ | ||
| Config_dict = self.task_config['config'] |
There was a problem hiding this comment.
Object instances should be lowercase.
Suggested change
| Config_dict = self.task_config['config'] | |
| config_dict = self.task_config['config'] |
There was a problem hiding this comment.
This line got changed, but the subsequent references to it weren't.
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Change characteristics
How has this been tested?
Checklist